fangohr / oommf

OOMMF source code in git repository
24 stars 7 forks source link

Update script to upload docker image 20a3 #37

Closed fangohr closed 3 years ago

fangohr commented 3 years ago

to Dockerhub.

marijanbeg commented 3 years ago

LGTM. I would maybe remove OOMMF version from filenames in docker/ to reduce the number of places where a change should be made with a new OOMMF version.

fangohr commented 3 years ago

LGTM. I would maybe remove OOMMF version from filenames in docker/ to reduce the number of places where a change should be made with a new OOMMF version.

I was torn between making it easier to track changes over time (for those not familiar with git) and being minimalistic. Let's go with your suggestion (see new commits.)

marijanbeg commented 3 years ago

+1