search

fangpenlin / avataaars

React component for avataaars
MIT License
792 stars 169 forks source link

fill-opacity not available on <g> #38

Open stact opened 3 years ago

stact commented 3 years ago

Following docs https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/fill-opacity fill-opacity attribute has no effect on

As a presentation attribute, it can be applied to any element but it has effect only on the following eleven elements: <altGlyph>, <circle>, <ellipse>, <path>, <polygon>, <polyline>, <rect>, <text>, <textPath>, <tref>, and <tspan>

The results (don't be scared ^^): image

I will create a PR to avoid this behavior to move fill-opacity to the right element. Hope this package is still maintained

stact commented 3 years ago

PR #39 created

stact commented 3 years ago

@fangpenlin @gkoberger is the project still maintained?

gkoberger commented 3 years ago

Hey I don't have access to this repo, but happy to merge things into my API if it gets merged here :)