search

fangq / mmc

Mesh-based Monte Carlo (MMC)
Other
37 stars 31 forks source link

mmclab no longer returns dept and seeds output when running on the CPU (gpuid=-1) #87

Closed fangq closed 6 months ago

fangq commented 6 months ago

Please see this report by Giovanna Tramontin in the mailing list https://groups.google.com/g/mcx-users/c/PdygHRn9Mcs

despite it is known (see #86) that photon sharing does not work on the GPU, the dept and seeds outputs from mmclab in the GPU actually reutrned non-empty outputs, but CPU (cfg.gpuid=-1) returned empty outputs.

I was able to confirm this regression. I am not sure when this started to happen. Need to fix.

fangq commented 6 months ago

the issue is now fixed as part of the following commit, specifically, this line

https://github.com/fangq/mmc/commit/ebefe98577bee6b9507fb695c4763ad67245c61d#diff-76885cc6201a298c5ef20e311fb6c88a7fc2cb3745c84d02830524656cae9d95R310