search

fani-lab / Adila

Fairness-Aware Team Formation
3 stars 2 forks source link

Zero before/after NDKL for every input after code refactor #51

Closed Hamedloghmani closed 1 year ago

Hamedloghmani commented 1 year ago

Today I have been struggling with this issue while trying to run my experiment for double cutoff method based on the refactored code. NDKL is always zero for every input. I am prioritizing the task of resolving this bug.

Hamedloghmani commented 1 year ago

My initial experiments show this might be because of a math function in conda.

Hamedloghmani commented 1 year ago

@hosseinfani Cause: reranking.ndkl function does not work with bool values. We changed the popularity labels to bool in refactor.

Solution: Change the popularity labels to 'p' and 'np' or string version of true/false

hosseinfani commented 1 year ago

Pls convert it in L#81-82

hosseinfani commented 1 year ago

@Hamedloghmani I'm fixing it ...

Hamedloghmani commented 1 year ago

@hosseinfani I already fixed it last night. Please wait for the push.

hosseinfani commented 1 year ago

@Hamedloghmani I pushed my changes. You pull. The reason was not about working with bool. See the message of the push and the change. Next time, please root cause the problem :)

Hamedloghmani commented 1 year ago

@hosseinfani Sure, sorry for the inconvenience. :)