fani-lab / LADy

LADy 💃: A Benchmark Toolkit for Latent Aspect Detection Enriched with Backtranslation Augmentation
Other
5 stars 6 forks source link

Setup and Quickstart #13

Closed farinamhz closed 1 year ago

farinamhz commented 1 year ago

This is an issue page to log the progress for setup and quickstart. @DeepKaran1 @hosseinfani

DeepKaran1 commented 1 year ago

I am working on the set-up part but None of Pip and Condo works for me even I have installed the packages for both of them.

hosseinfani commented 1 year ago

@DeepKaran1 Can you post the error message or sth here?

farinamhz commented 1 year ago

Hi @DeepKaran1, Post the error text or snapshot here, or you can come to the lab today, and we can discuss it there to solve it.

DeepKaran1 commented 1 year ago

@Farinamhz, I have solved that issue on my own and I am going to finish all the set-up process hopefully by today.

farinamhz commented 1 year ago

Hi @DeepKaran1, Have you been able to finish the setup and quickstart, and see the results?

DeepKaran1 commented 1 year ago

Screenshot (2603) Screenshot (2604)

These are the screenshots for errors.

farinamhz commented 1 year ago

@DeepKaran1 As written in the readme, you need to install Microsoft C++ Build Tools as a requirement in btm.

DeepKaran1 commented 1 year ago

This does not work Screenshot (2608)

farinamhz commented 1 year ago

@DeepKaran1 Try this

pip install pytrec-eval-terrier

and then comment the pytrec library from requirements.txt and then install again from requirements and check whether it works.

DeepKaran1 commented 1 year ago

No that does not work

farinamhz commented 1 year ago

Same error? @DeepKaran1

DeepKaran1 commented 1 year ago

Yes.

farinamhz commented 1 year ago

@DeepKaran1 Have you been able to install pytrec using

pip install pytrec-eval-terrier

and the error is for the requirement.txt installation, or do you get the error while you install using the above command?

DeepKaran1 commented 1 year ago

I tried both ways first just by above command and afterwards by commenting that in requirements.txt and install it using requirements. Both give me same error.

farinamhz commented 1 year ago

@DeepKaran1 Actually, when you comment in requirements.txt you can not install it using requirements anymore. I mean when you comment it and just install it with that command I told you, that command also does not work alone?

DeepKaran1 commented 1 year ago

No, that command does not work alone.

farinamhz commented 1 year ago

@DeepKaran1 what is the version of your python?

DeepKaran1 commented 1 year ago

3.11

farinamhz commented 1 year ago

@DeepKaran1 Try 3.8 or 3.9, please and see if the problem will be solved.

farinamhz commented 1 year ago

@DeepKaran1 Also check out this issue page from pytrec: issue page

hosseinfani commented 1 year ago

@DeepKaran1 @farinamhz Why don't you meet and solve the issue together?!

farinamhz commented 1 year ago

@hosseinfani, We are going to meet tomorrow about this issue.

farinamhz commented 1 year ago

Update: the problem was with the python version that it probably should be 3.9 or 3.8 (not higher!) to be able to install the requirements. Also, I resolved some problems with the paths and importing, and there is no problem with the code for running now. However, Karandeep is still working on that due to git problems. So, please update your progress here @DeepKaran1, and report in case of an error.

hosseinfani commented 1 year ago

Hi @DeepKaran1 , It's been a month since you started installing this codebase, and still no success. I'm afraid, this progress is not on par with our lab standard. Either finish this task by the end of this week, or you'll be invited to leave the lab. Thank you.

DeepKaran1 commented 1 year ago

@hosseinfani Sorry Dr. Fani It was my bad I have not updated you, I already have completed that task 2 weeks ago and working on next part after discussing it with farinam. Even you can ask her(farinam) for more clarification.

Thanks Karandeep

hosseinfani commented 1 year ago

@farinamhz what's @DeepKaran1 's next task and where he puts his progress?

farinamhz commented 1 year ago

@hosseinfani Yes, he has finished it before, and I have already assigned the issue of XML reader for semeval to Karandeep. We had a meeting when he finished, and we discussed the problem, and I explained the dataset and his part to him. However, I have told him before that he need to log his progress here before.

DeepKaran1 commented 1 year ago

Dr. Fani I am afraid, as I am in Toronto spending some quality time with my family it will be quite challenging for me, but I will try my best to complete it.