Needing for update in OCTIS library

fani-lab / LADy

LADy 💃: A Benchmark Toolkit for Latent Aspect Detection Enriched with Backtranslation Augmentation

Other

3 stars 3 forks source link

Needing for update in OCTIS library #56

Open farinamhz opened 9 months ago

farinamhz commented 9 months ago

Hi @hosseinfani, OCTIS has been updated in its original repository, and I think the problem with their scikit version requirement has been resolved as I checked out their updates.

Hence, we'll need to update our OCTIS repo in Fani-lab.

@3ripleM

hosseinfani commented 9 months ago

@farinamhz Thanks for the update. We need to merge their changed carefully to our fork in fani's lab. Please work together with @3ripleM and do the merge.

thank you.

farinamhz commented 6 months ago

I sent a PR for merging: https://github.com/fani-lab/OCTIS/pull/1 and I believe we can close this issue now. @hosseinfani