fani-lab / LADy

LADy 💃: A Benchmark Toolkit for Latent Aspect Detection Enriched with Backtranslation Augmentation
Other
4 stars 5 forks source link

Setup Modification #75

Open Sepideh-Ahmadian opened 2 months ago

Sepideh-Ahmadian commented 2 months ago

Hello Dr. @hosseinfani and teammates,

I’m thrilled to be a part of the Lady project and to work alongside you all! This is my first issue, and I’ve noticed a few things during the setup process.

Missing Libraries While setting up the environment, I noticed that the following libraries are not included in the environment.yml or requirements.txt: 1) Pampy: 0.3.0 2) Returns: 0.22.0 3) more-itertools: 10.1.0 These libraries seem to be necessary for the project to function correctly.

Issue with SpaCy Model Download Additionally, I encountered an issue when trying to download the en_core_web_sm model using the following command: python -m spacy download en_core_web_sm I had the following error. TypeError: issubclass() arg 1 must be a class. This error can be rectified by updating the SpaCy version to 3.7.2. It might be helpful to update this version in the environment as well.

Proposed Changes I propose the following changes to the requirement files: Adding the following requirements: 1) Pampy 0.3.0 2) Returns 0.22.0 3) More-itertools 10.1.0

Changing the version: 1) SpaCy 3.3.1 -> 3.7.2

hosseinfani commented 2 months ago

thank you @Sepideh-Ahmadian just for yml, check if conda channels has the packages or it should be pip. then please push.

Sepideh-Ahmadian commented 2 months ago

Sure Dr. @hosseinfani, I will push the modifications tomorrow morning.

Sepideh-Ahmadian commented 2 months ago

@hosseinfani I have applied the changes. However, the recent changes caused this problem.

Capture docker

hosseinfani commented 2 months ago

@Sepideh-Ahmadian I think if you make the scikit version to 1.0, it fixes the issue

Sepideh-Ahmadian commented 2 months ago

Currently in both files the scikit-learn version is: scikit-learn>=1.0.0

Sepideh-Ahmadian commented 2 months ago

@hosseinfani I have changed the spacy's version and added three more libraries. Do you mean I should change spacy's version to previous one?

hosseinfani commented 2 months ago

@Sepideh-Ahmadian I said that based on the error message