search

fani-lab / ReQue

A Benchmark Workflow and Dataset Collection for Query Refinement
https://hosseinfani.github.io/ReQue/
Other
0 stars 13 forks source link

Adding backtranslation expander #29

Closed DelaramRajaei closed 1 year ago

DelaramRajaei commented 1 year ago
hosseinfani commented 1 year ago

Hi @DelaramRajaei Thank you for the nice changes. I put some comments. Please address them. Also, attach a script or sth in the issue page that shows the smooth run of the pipeline with added features as a unit/integration test.

DelaramRajaei commented 1 year ago

Hi @hosseinfani I updated some comments I remembered but unfortunately, I can not see the comments you put on the code. Also, I update the return of all the expanders. In this new update, the semsim score is stored in both txt and csv files.

Also, attach a script or sth in the issue page that shows the smooth run of the pipeline with added features as a unit/integration test.

Could you please explain this a little? Can I attach the csv file as results?

hosseinfani commented 1 year ago

@DelaramRajaei I had to submit my comments. Now you can see them I believe.

DelaramRajaei commented 1 year ago

@hosseinfani I went through the comments and implemented the suggested changes. I pushed the updated version.

hosseinfani commented 1 year ago

Hi @hosseinfani I updated some comments I remembered but unfortunately, I can not see the comments you put on the code. Also, I update the return of all the expanders. In this new update, the semsim score is stored in both txt and csv files.

Also, attach a script or sth in the issue page that shows the smooth run of the pipeline with added features as a unit/integration test.

Could you please explain this a little? Can I attach the csv file as results?

@DelaramRajaei let me when you're available today (check msteams). I'll explain more then.

hosseinfani commented 1 year ago

@DelaramRajaei just a quick check, if an expander is not a backtranslated one, there is no problem with semsim value?