search

fanningert / kirbycms-extension-image

KirbyCMS Extension - Image Extended
http://www.fanninger.at/thomas/works/kirbycms-extension-image
GNU General Public License v3.0
28 stars 2 forks source link

kirby-2.1.1 security update breaks kirbycms-extension-image #16

Closed aagd closed 9 years ago

aagd commented 9 years ago

Parse error: syntax error, unexpected '[' in /Users/username/Sites/kirby/site/plugins/kirbycms-extension-image/kirbycms-extension-image-lib-block-object.php on line 88

Maybe a similar issue as with the video extension. I tried it with a clean new kirby install without extra plugins.

Update: The problem does occur only on PHP 5.3. On PHP 5.6 all works fine.

fanningert commented 9 years ago

Interesting. I will check it. Ok, this is a feature what is new at PHP 5.4.0. http://php.net/manual/en/migration54.new-features.php

aagd commented 9 years ago

Mine was 5.3.29. Now on 5.6.12 the error is gone...

fanningert commented 9 years ago

@aagd Sorry, I updated my post.

fanningert commented 9 years ago

@aagd I made a little correction. Can you test it? https://github.com/fanningert/kirbycms-extension-image/commit/4f0d43e95ca073bcea0c0482a1c30cf789cfc555

aagd commented 9 years ago

Now it's Parse error: syntax error, unexpected '[' in /Users/username/Sites/kirby/site/plugins/kirbycms-extension-image/kirbycms-extension-image-lib-block-object.php on line 217

fanningert commented 9 years ago

Ok the some error on a other position. I think this will not the last position of the problem. I will correct the problem tomorrow.

aagd commented 9 years ago

Very cool, thanks!

fanningert commented 9 years ago

@aagd Can you test it. I updated the code for 5.3 support. I don't know if there is another one position with the same problem. I am not able to test it, because I have no machine with 5.3 at the moment. 5fa5958a7c9153eb295a7f17fb7dfba1e9883e50

aagd commented 9 years ago

Yes sure, I'll try this tomorrow. Have to leave now...

aagd commented 9 years ago

Looks good, error is gone.