search

fanout / django-eventstream

Server-Sent Events for Django
MIT License
638 stars 84 forks source link

Add capability to have a list for CORS ORIGIN #137

Closed erfantarighi closed 4 months ago

erfantarighi commented 4 months ago

I added capability to set a list instead of str for CORS because I need to have a different ORIGINS

jkarneges commented 4 months ago

Hi! Thanks for offering this contribution. However, as of version 5.0.0, django middleware is supported, so if you want better CORS capabilities you can just use django-cors-headers (or make your own middleware) without needing to modify this library. The EVENTSTREAM_ALLOW_* options should be considered deprecated. If you still prefer to have this PR merged let me know.

erfantarighi commented 4 months ago

Hi! Thanks for your update, but we don't use the django-cors-headers, if it's possible merge it, if it's not possible I can write a middleware for it

jkarneges commented 4 months ago

Done! Thank you.