fanout / django-eventstream

Server-Sent Events for Django
MIT License
638 stars 84 forks source link

Improve logging #146

Closed verhovensky closed 2 months ago

verhovensky commented 2 months ago

Would be great if we add some configured logging on event send. To be able to see logs from Django itself if we do not use Pushpin of FanOut services For example here:

    def add_to_queues(self, channel, event):
        self.lock.acquire()
        try:
            wake = []
            listeners = self.listeners_by_channel.get(channel, set())
            for listener in listeners:
                items = listener.channel_items.get(channel)
                if items is None:
                    items = []
                    listener.channel_items[channel] = items
                if len(items) < MAX_PENDING:
                    items.append(event)  # here
                    wake.append(listener)
                else:
                    listener.overflow = True
            for listener in wake:
                listener.wake_threadsafe()
        finally:
            self.lock.release()

Thoughts?

jkarneges commented 2 months ago

Good idea. I've added some log messages.