fanout / django-eventstream

Server-Sent Events for Django
MIT License
650 stars 85 forks source link

Default number of limit on channel numbers #16

Closed LihengGong closed 6 years ago

LihengGong commented 6 years ago

From source code, I can see that the default number of limit for the maximum channel number is 10.

My question is: If I do not overwrite this value, does that mean there are only as many as 10 channels?

def __init__(self, http_request=None, channel_limit=10, view_kwargs={})
LihengGong commented 6 years ago

I raised this issue because when testing with the chat example, I can see that Django stops responding if there are more than 6 rooms(http://localhost:9000/room1?user=1; ...; http://localhost:9000/room6?user=1) or more than 6 users(http://localhost:9000/room1?user=1; ....; http://localhost:9000/r1?user=6).

jkarneges commented 6 years ago

Yes. This is a conservative default that should probably be turned into a setting so you don't have to write your own view to change the value.

LihengGong commented 6 years ago

Thanks. Close this issue for now.