search

fanout / django-eventstream

Server-Sent Events for Django
MIT License
650 stars 85 forks source link

Don't implicitly require the staticfiles app when using the runserver… #3

Closed svvitale closed 6 years ago

svvitale commented 6 years ago

…_ngrok command.

jkarneges commented 6 years ago

This seems reasonable, but I can't reproduce a problem. If I comment out django.contrib.staticfiles from INSTALLED_APPS, the command still works. Is it moreso that using a non-installed app is bad style?

svvitale commented 6 years ago

The issue arises when you don't have a STATIC_URL set in your settings.py file:

django.core.exceptions.ImproperlyConfigured: You're using the staticfiles app without having set the required STATIC_URL setting.

I prefer to check for the staticfiles app in case STATIC_URL changes or is removed in the future (even though that's pretty unlikely).

jkarneges commented 6 years ago

Ah! Makes sense. Thanks.