search

fanout / django-eventstream

Server-Sent Events for Django
MIT License
638 stars 84 forks source link

Deprecated usage for MiddlewareMixin #84

Closed Schlepptop closed 2 years ago

Schlepptop commented 2 years ago

As of this commit to the Django codebase, this will no longer work, as the MiddlewareMixin will require an argument for get_request:

https://github.com/fanout/django-eventstream/blob/57d4456f5da85e7f0139cd9ccfdfc8581bd42726/django_eventstream/consumers.py#L137

fmgoncalves commented 2 years ago

There is a PR open to deal with this https://github.com/fanout/django-eventstream/pull/82

Schlepptop commented 2 years ago

Oh, indeed. Didn't see that :)

jkarneges commented 2 years ago

The fix has been merged.