search

fanquake / core-review

Scripts, tools & info for doing Bitcoin Core development and code review
https://github.com/bitcoin/bitcoin
109 stars 33 forks source link

guix: autodetect build arch in the Dockerfile #18

Closed prusnak closed 3 years ago

prusnak commented 3 years ago

This PR makes Docker autodetect arch during the container build.

It also contains overall improvements of the Dockerfile

maflcko commented 3 years ago

You could also base this on debian:bullseye, which already ships with guix on all archs that guix claims to support as well.

dongcarl commented 3 years ago

Concept ACK! Paves the way for running Guix builds on different architectures! I made the manifest in Bitcoin Core host-architecture agnostic so that we could pursue this in the future!

tenor

dongcarl commented 3 years ago

You could also base this on debian:bullseye, which already ships with guix on all archs that guix claims to support as well.

True, perhaps we can do so in another PR!

prusnak commented 3 years ago

I think it's better not to drag Debian into the mix and keep it simple

fanquake commented 3 years ago

You could also base this on debian:bullseye, which already ships with guix on all archs that guix claims to support as well.

True, perhaps we can do so in another PR!

I've got a Dockerfile for this. Will PR shortly.