fantahund / FancyFirework

Fun with Firework
https://www.spigotmc.org/resources/fancyfirework.98809/
GNU General Public License v3.0
7 stars 3 forks source link

utilize paper player profiles #1

Closed jeffschulthies closed 2 years ago

jeffschulthies commented 2 years ago

Not sure what the proper way to do this is. I want to utilize fancy fireworks as a dependency to one of the plugins I'm developing. I tried adding the dependency using jitpack but it had problems compiling. This would utilize the paper api instead of using the internal mojang libraries for profiles.

fantahund commented 2 years ago

Unfortunately, I can not accept the so a the plugin is then no longer Spigot compatible. Will tonight but still care about a solution that it builds with the spigot api and not with spigot.

jeffschulthies commented 2 years ago

Yeah understood I'll just run a fork for now just wanted to toss some ideas out there

fantahund commented 2 years ago

But do you want to tell me what you need the plugin for as a dependency? :>

jeffschulthies commented 2 years ago

Yes! I have some minigames that I'd like to add more fanfair too and I really enjoy the fountains that are provided

fantahund commented 2 years ago

So now the plugin builds with the spigot api. And just for info a version other than java 17 makes no sense. ^^

jeffschulthies commented 2 years ago

thanks for the tweak. just wondering what's the reasoning behind not having anything other than java 17? I'm super rusty on my Java

fantahund commented 2 years ago

1.18 Minecraft servers and Minecraft clients also require Java 17.

jeffschulthies commented 2 years ago

@fantahund this is the idea of what I'm going for. I played around with removing the armorstand requirement since I just want to spawn the particle effects. gif

fantahund commented 2 years ago

Just had a look at it. It is not so easy to change the system so that you only spawn the fireworks without armor stands.

jeffschulthies commented 2 years ago

Yeah I hacked something together in my fork for my use case just wanted to share how I'll be using it since I saw the comments on your spigot post https://www.spigotmc.org/resources/fancyfirework.98809/reviews about customizing defaults, etc

fantahund commented 2 years ago

^^