fantahund / VoxelMap

24 stars 6 forks source link

[DO NOT MERGE YET] Code Deep Clean #5

Closed TheAlgorithm476 closed 1 year ago

TheAlgorithm476 commented 1 year ago

The goal of this PR is to clean up VoxelMap's 1.19.2 codebase, to give no chance to eventual compiler or logic bugs, caused by the initial decompilation from the 1.17 JAR. Every commit added to this Pull Request is tested by me for any immediate effects, and will not be submitted if any visible bugs are introduced.

I will update the title of this PR when I think the source is clean enough to be merged into the VoxelMap mainline branch. This side project will hopefully fix the bug we're facing in the current 1.19.3 branch, that we can't fix due to the code's complexity and readability.

Be free to leave comments or suggestions on how to take care of this long-overdue cleanup. // Algo

TheAlgorithm476 commented 1 year ago

The hard part is over. Most of the raw types have been assigned a generic type, and afaik, all OpenGL call values have been replaced by their OpenGL names. Everything still works as usual, except a little bit faster it seems.

TheAlgorithm476 commented 1 year ago

Everything above this line is included into 1.12.0+R1-beta

TheAlgorithm476 commented 1 year ago

Note to self: That one reverted commit was responsible for the map not willing to load. Don't touch CompressibleMapData for the next few days

TheAlgorithm476 commented 1 year ago

Everything above this line is included into 1.12.0+R1-beta2

TheAlgorithm476 commented 1 year ago

Everything above this line is included into 1.12.0+R2-beta

TheAlgorithm476 commented 1 year ago

Everything above this line is included into 1.12.0+R3-beta

Notable changes in this release:

TheAlgorithm476 commented 1 year ago

Here goes nothing