search

fantasticmachine / existential

Simple Craft 3 plugin that adds a Twig filter for checking whether a file exists
MIT License
3 stars 2 forks source link

Craft v4 update #5

Closed tyssen closed 1 year ago

tyssen commented 1 year ago

First time I've done any plugin work for v4 or a PR for that matter, so hope I've go this right.

peteeveleigh commented 1 year ago

Thanks @tyssen. I really appreciate your help and apologies for not getting to this myself. I've merged in this PR

tyssen commented 1 year ago

Is there something else you need to do on the Craft end? Because when I check the upgrade page in my site's control panel, it still says Not Ready.

peteeveleigh commented 1 year ago

Ah yes, I’ll need to tag a release for it. Will do that today

On 2 Mar 2023, at 23:45, John Faulds @.***> wrote:

Is there something else you need to do on the Craft end? Because when I check the upgrade page in my site's control panel, it still says Not Ready.

— Reply to this email directly, view it on GitHub https://github.com/fantasticmachine/existential/pull/5#issuecomment-1452732476, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGJ5OLXKU3ZKAU66KVXE7TW2EWIXANCNFSM6AAAAAAVM6J3GQ. You are receiving this because you modified the open/close state.

peteeveleigh commented 1 year ago

You should now find your update is available. Thanks for doing that :)

On 2 Mar 2023, at 23:45, John Faulds @.***> wrote:

Is there something else you need to do on the Craft end? Because when I check the upgrade page in my site's control panel, it still says Not Ready.

— Reply to this email directly, view it on GitHub https://github.com/fantasticmachine/existential/pull/5#issuecomment-1452732476, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGJ5OLXKU3ZKAU66KVXE7TW2EWIXANCNFSM6AAAAAAVM6J3GQ. You are receiving this because you modified the open/close state.

tyssen commented 1 year ago

Sorry, took me a while to get back to this. This is what I'm seeing in the Craft CP:

image

tyssen commented 1 year ago

Hi @peteeveleigh Craft 4 updates page is still showing it as being not ready.

peteeveleigh commented 1 year ago

@tyssen Ugh, sorry. I don't know what is going on with this. I'll try and take a look later and nuke it from orbit or something.