search

fantasycalendar / Fantasy-Calendar

Build a calendar that fits your world! Whether you're a GM just here to track your Forgotten Realms campaign with a preset calendar, or a fanciful world-builder with 12 moons (Like Eberron's) and zany timekeeping systems to match, we've got you covered.
https://app.fantasy-calendar.com
94 stars 7 forks source link

"Embed this calendar" option #7

Open V13Axel opened 5 years ago

V13Axel commented 5 years ago

A user mentioned embedding their calendar via an iframe on another site. Would be cool if we could officially support that somehow, make it more user-friendly. Perhaps generating Wiki markdown and other formats?

Just a thought.

DoNotResuscitate commented 2 years ago

Any plan to work on this feature?

V13Axel commented 2 years ago

@DoNotResuscitate Embedding is already a thing - What kind of work are you proposing be done on it? Apparently we need to do some issue cleanup =]

Haxxer commented 2 years ago

Indeed, it is as Axel says, this is supported already!

image

image

DoNotResuscitate commented 2 years ago

@V13Axel I was looking for an embed on the actual calendar view. Just realized it's on the calendar list view.

DoNotResuscitate commented 2 years ago

I don't think the help docs mention embeds though, unless I'm just missing the section.

V13Axel commented 2 years ago

Ah! I can see how updating the share functionality to provide that a menu item could be a useful thing to avoid such confusion. Sorry about that

DoNotResuscitate commented 2 years ago

Though it seems the embed isn't working. The preview doesn't even load. firefox_2022-09-08_18-21-07

Haxxer commented 2 years ago

That is a known bug, you need to be a subscriber to be able to customize it - this will be replaced with an image that lets you know of this fact in a future update.

ReconVirus commented 1 year ago

That is a known bug, you need to be a subscriber to be able to customize it - this will be replaced with an image that lets you know of this fact in a future update.

If i understand correctly embedded is only for subscribers, currently when i tried without using a theme i still run into this issuse

tctlrd commented 6 months ago

When I spin-up the dev environment I have this bug and cannot embed. Is it possible for embed to work in a dev/local environment? I was able to get it working with the unified Dockerfile (after updating it...); so it does not really matter.

V13Axel commented 6 months ago

@tctlrd At the moment, the local docker-based dev environment has an issue where it can't serve up the images directly, due to the way it's emulating AWS Lambda (which the main FC app is hosted through) - It's an issue with the brefphp dev containers that I keep meaning to go look closer at. I do my development without using docker most of the time though, so I haven't cared enough to look into getting it to work there.

tctlrd commented 6 months ago

@V13Axel Thank you for explaining! Don't worry about it. The app works very well now that I have figured out how to build the unified docker image.