fantasycalendar / FoundryVTT-ItemPiles

Other
33 stars 54 forks source link

[BUG] - Dark Heresy 2 - Missing Translation for "No currency" #306

Closed diwako closed 1 year ago

diwako commented 1 year ago

Have you tried to reset Item Piles' system settings? No, no need as the system is not supported

Describe the bug While adding support for the Dark Heresy 2 system, which has no currency, I noticed this when accidentally hitting the add currency button. image

To Reproduce Steps to reproduce the behavior:

  1. Create world with any unsupported system
  2. Place down any token
  3. make token a pile
  4. Try to add currency to the pile

Expected behavior Text is shown that the system does not support currency or has none

Screenshots uuh, see above

Setup:

Active modules:

Additional context None

Haxxer commented 1 year ago

You shouldn't be able to add currencies to the piles if the system doesn't have any, so less of a localization bug and more of a bug-bug.

diwako commented 1 year ago

Well, glad to find bugs. I just thought it was simply a missing translation.

Haxxer commented 1 year ago

Fixed in 2.5.4