fantasycalendar / FoundryVTT-ItemPiles

Other
34 stars 54 forks source link

[BUG] - [v11] - Item piles are prefilled with invalid items #489

Closed somedndaccount closed 9 months ago

somedndaccount commented 9 months ago

Have you tried to reset Item Piles' system settings? Yes

Describe the bug Newly created item piles in v11 have some historically created items in there. removing them or deleting them from the sheet is not possible and results in an error since the ID cannot be found image

To Reproduce Steps to reproduce the behavior:

Use item piles in earlier version Update to v11 delete itempiles module, restart game and enable Create an item pile or interact with existing ones Item Pile has the item in it and several invalid ones they cannot be removed by setting to 0, moving them out, going to the sheet and trying to delete them - they are stuck. Interacting with them gives and error image

image

Expected behavior Item pile has the one item in that you dragged on the map and/or: faulty items can be deleted centrally to restore the expected behaviour

Setup:

Active modules:

Additional context Add any other context about the problem here.

Haxxer commented 9 months ago

Can you check if your default item pile has a linked token, and whether it has items stored in it? The default item pile is used anytime you create a new item pile, so its content gets duplicated. Could you also try with just item piles and its dependencies to see if it is truly an item piles module issue?

somedndaccount commented 9 months ago

wow. yes, will do i did check the default token, and it does have the same items - i already guessed that's what causes the problems - the issue is i can't do anything about those items, foundry throws an error as outlined in the ticket each time. will try to disable all modules image

somedndaccount commented 9 months ago

image after disabling all modules, it actually migrated something, and now the token appears to be functioning as expected. thank you.

somedndaccount commented 9 months ago

small followup question if you check this out again - previously i could open a newly created pile, immediately save it and the token on the map would change to the name of the item inside it - is that removed functionality or did i miss a setting somewhere? Could also have been a sideeffect of an addon back in v9, but i might as well ask

StevenEvans1966 commented 9 months ago

I created a wfrp game with no other modules but item piles. I place 2 item piles on a scene, reloaded the game. Found all the items on the scene had been coped to the default item and both piles contain their items plus the other pile's item.

there appears to be some migration happening not sure why as this is a clean world with the latest versions

I have included the log for completeness

error.log

rinnocenti commented 9 months ago

For me, markets without a link to the original actor do not update and issue errors. Even though the link has already been updated, it tries and keeps trying, causing slowdowns in the system.

image

Haxxer commented 9 months ago

@rinnocenti @StevenEvans1966 @somedndaccount Sorry for the issue, do you think you could test this beta release and see if the duplication bug still occurs?

https://github.com/fantasycalendar/FoundryVTT-ItemPiles/releases/download/2.8.!5/module.json

StevenEvans1966 commented 9 months ago

I reopened the test world. some errors where reported but both the scene piles and the default had there correct contents. A second reopen produced no errors.

Haxxer commented 9 months ago

Excellent. You should be able to update item piles, and this bug should be no more.