fantasycalendar / FoundryVTT-ItemPiles

Other
34 stars 54 forks source link

[BUG] - PF2e - Default sharing settings ignored when Item Pile created from NPC #494

Closed this-gavagai closed 8 months ago

this-gavagai commented 8 months ago

Have you tried to reset Item Piles' system settings? Yes

Describe the bug I'm having trouble getting default sharing settings to work. I have followed the instructions from the wiki to adjust the "Default Item Pile Actor", and that works if I drag an item to the canvas. On the other hand, if I create an Item Pile directly from a Token that has been made lootable by setting "Enabled" from the NPC character sheet, the original Sharing Settings come through instead.

To Reproduce Steps to reproduce the behavior:

  1. Set alternate defaults for sharing settings in the Default Item Pile actor.
  2. Drag a new NPC to the canvas
  3. Open the sheet for an NPC token
  4. Click on Item Piles Configuration in the header bar
  5. Observe that sharing settings do not match the Default Item Pile actor's settings.

Expected behavior The "lootable" token should use the Default Item Pile's sharing settings.

Setup:

Active modules:

Haxxer commented 8 months ago

Simply setting it to enabled will not share the setting - I can do this, but I would recommend using this macro instead: https://fantasycomputer.works/FoundryVTT-ItemPiles/#/sample-macros?id=make-tokens-lootable

this-gavagai commented 8 months ago

Ah, that works great. I didn't realize there was a difference between using the API and the tickbox. This solves the issue, though.