fantasycalendar / FoundryVTT-ItemPiles

Other
33 stars 52 forks source link

[BUG] - [SWB] - Purchase Macro only works on GM #523

Closed Manume96 closed 5 months ago

Manume96 commented 5 months ago

Are you on the latest version of Item Piles? Yes

Have you tried to reset Item Piles' system settings? Yes

Describe the bug I have a item service that execute a macro (right now the macro only shows a ui notification) but when a player purchase the service the ui notification only appear for the DM

To Reproduce Create a macro, select it on the item configuration to execute when buy it, as a player buy the item. The item does not execute for the player but the dm see the notification (the ui notification is because do other stuff but wasn't working.

Expected behavior See the ui notification on the player screen

Screenshots image The left image is the DM running of the browser and the right one is the player, as you can see the player just did the purchase but doesn't see the notificacion while the DM can.

Setup:

Active modules:

Haxxer commented 5 months ago

Changing this now would risk breaking macros for everyone who is currently using them. The reason why I chose to run it on the GM side is to make it so that it could update anything that the GM wanted to, such as attributes on characters, or create new items, etc. This also gets around the permission issue that players cannot run macros they do not have permission to run.

This is not a bug, this is an intended design. If you wish it to work in a different way, make a feature request.

Manume96 commented 5 months ago

So, for explample, in this case i want my merchant to have a service to refill the water, in case the player have the bottle full, i can't make a message pop up to notify it?

Haxxer commented 5 months ago

Correct - I reiterate, if you want to execute a macro on the player side, please make a feature request.