search

fantasycalendar / FoundryVTT-ItemPiles

Other
33 stars 52 forks source link

[BUG] - [DND5e] - Dropping a container from inventory drops ONLY the container #527

Open IHaveThatPower opened 5 months ago

IHaveThatPower commented 5 months ago

Are you on the latest version of Item Piles? Yes - 2.8.20

Have you tried to reset Item Piles' system settings? Yes

Describe the bug When a container-type item is dragged from a character sheet's inventory to the game canvas and dropped to create a new pile, the contents of the container remain behind in the character's inventory.

To Reproduce Steps to reproduce the behavior:

  1. Create a scene.
  2. Create a player character.
  3. Create a Backpack container item.
  4. Drag the Backpack item from the Item list into the character's inventory.
  5. Create another item of any type.
  6. Open the Backpack item from the inventory and drag the other item into the Backpack item's "Contents" space
  7. Drag the Backpack item from the character's inventory to the game canvas.
  8. Confirm the creation of a new pile when prompted.

Expected behavior When a container is dragged from inventory, all of its contents should go with it.

Setup:

Active modules:

Additional context Observed this both in an existing Foundry world with many modules enabled, and a freshly-created one with only Item Piles and its dependencies turned on.

JoueurSansFromage commented 5 months ago

I have the same issue, looking forward for a fix!

EternalRider commented 5 months ago

Mabe my issue 524 can be solved at the same way.

Provides an API that allows additional items to be appended to the transfer when any Item is transferred via the Item Piles any function, all the need like this could be solved.

JoueurSansFromage commented 1 month ago

I was just wondering if this feature/bug is planned to be adressed? I really enjoy Item Piles and I'm considering downgrading my D&D system upgrade to make this feature work, but I'm unsure how it would work with my world migrated already.

I use variant encumberance and partly because I knew Item piles would make it work hahaha!

McShaker commented 1 week ago

Would love a fix here. I also use variant encumbrance and dropping bags with contents is the best solution.

Haxxer commented 1 week ago

See pull request which is under works. I am working on this for free on my free time, if you wish to help, you can contribute on the pull request:

https://github.com/fantasycalendar/FoundryVTT-ItemPiles/pull/589