Closed Forien closed 4 months ago
Custom Category also does not work with nested tables, this time due to errors (and regardless of Add all items
setting):
commons.js:2570 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'customCategory')
at setProperty (commons.js:2570:16)
at pile-utilities.js:2047:6
at Array.forEach (<anonymous>)
at rollMerchantTables (pile-utilities.js:2045:15)
at async evaluateTable (MerchantPopulateItemsTab.svelte:122:9)
This happens when Custom Category
is set to a Rollable Table that has other Rollable Tables as a results:
Fixed in 2.9.0
Are you on the latest version of Item Piles? Yes
Have you tried to reset Item Piles' system settings? No
Describe the bug When populating the Merchant with items from Rolltables, the selected "custom category" is not applied.
However, it seems to sometimes work, so after some testing I noticed that it only works if
Add all items
is checked, but not if it's unchecked.To Reproduce Steps to reproduce the behavior:
Populate Items
tabAdd items to custom category
Add all items
is not checkedtype
insteadExpected behavior Items should use custom category even if
Add all items
is not checkedScreenshots n/a
Setup:
Active modules:
Module List
``` Core Version: 11.315 System: wfrp4e 7.0.3 (Moo Man, CatoThe1stElder) Modules: ATL 0.7.0 (Kandashi, kaelad) JB2A_DnD5e 0.6.5 (Jules, Ben) _chatcommands 2.0.2 (Cody Swendrowski, The League of Extraordinary FVTT Developers, Adrian Haberecht) arms-reach v2.3.3 (Psyny, p4535992) autoanimations 4.2.71 (Otigon (Otigon#2010)) chat-commander-wfrp4e 0.1.4 (Forien) custom-css 2.2.2 (zeel, Cody Swendrowski) darkraven-games-soundscapes-free 1.2.1 () dfreds-chat-pins 3.0.0 (DFreds) dfreds-effects-panel 3.1.1 (DFreds) dice-so-nice 4.6.10 (Simone, JDW) forien-actors-summary 0.1.3-beta (Forien) forien-ammo-swapper 0.3.0 (Forien) forien-armoury 1.4.1 (Forien) forien-copy-environment v2.2.0 (Blair McMillan, Forien) forien-easy-polls 1.0.7 (Forien) foundryvtt-simple-calendar 2.4.3 (Dean Vigoren (Vigorator)) image-hover 3.0.3 (Eriku) item-piles 2.8.20 (Wasp) ivan-duch-music-packs 2.0 (Ivan Duch) lib-wrapper 1.12.13.0 (Rui Pinheiro) local-shared-compendiums 1.0.0 () michaelghelfi 1.4 () moulinette-core 11.7.3 (Sven Werlen) moulinette-imagesearch 11.0.1 (Sven Werlen) moulinette-scenes 11.1.5 (Sven Werlen) moulinette-tiles 11.1.3 () multi-token-edit 1.59.1 (Aedif) permission_viewer 11.5 (Matheus Clemente) polyglot 2.4.2 (Matheus Clemente) popout 2.16 (KaKaRoTo, Posnet) quick-insert 2.8.5 (Sunspots) remote-highlight-ui 2.0.0 (shemetz) sequencer 3.1.4 (Wasp) socketlib 1.0.13 (Manuel Vögele) soundfxlibrary 1.0.2 (CDeenen) stairways 0.10.2 (Simon Wörner) sweetnothings 1.5.0 (Geekswordsman) tabletop-rpg-music 3.1.0 (Tabletop RPG Music) times-up 11.1.2 (tposney) token-action-hud-core 1.5.3 (Larkinabout, Drental, ^ and stick) token-action-hud-wfrp4e 0.0.13 (Forien) token-ease 1.2.1 (Wasp, Kerrec Snowmane) token-variants 4.62.6 (Aedif) update-your-password 1.1.0 (Richard Robertson) wall-height 5.1.4 (theripper93, Ian Murphy, Cole Schultz) wfrp4e-altdorf 4.0.1 (Moo Man, Published by Cubicle 7) wfrp4e-archives1 4.0.2 (Moo Man, Published by Cubicle 7) wfrp4e-archives2 4.0.2 (Moo Man, Published by Cubicle 7) wfrp4e-core 4.0.2 (Moo Man, Published by Cubicle 7) wfrp4e-dotr 4.0.2 (Moo Man, Published by Cubicle 7) wfrp4e-eis 4.0.1 (Moo Man, Published by Cubicle 7) wfrp4e-eis-maps 6.0.2 (LeRatierBretonnien) wfrp4e-gm-toolkit 6.0.5 (Jagusti) wfrp4e-random-treasure 1.0.15 (fmunoz) wfrp4e-rnhd 4.0.1 (Moo Man, Published by Cubicle 7) wfrp4e-salzenmund 4.0.1 (Jagusti, Moo Man, Published by Cubicle 7) wfrp4e-starter-set 4.0.0 (Moo Man, Published by Cubicle 7) wfrp4e-ubersreik-maps 6.0.1 () wfrp4e-unofficial-grimoire 7.0.0 () wfrp4e-up-in-arms 4.0.1 (Moo Man, Published by Cubicle 7) wfrp4e-wom 4.0.1 (Moo Man, Published by Cubicle 7) wfrp4e-zoo 4.0.1 (Jagusti, Moo Man, Published by Cubicle 7) ```