search

fantasycalendar / FoundryVTT-ItemPiles

Other
33 stars 52 forks source link

Externalize some utilities method to the api #542

Closed p4535992 closed 4 months ago

p4535992 commented 4 months ago

I only needed the isMerchant but while I was at it I did it for all types including the Auctioneer ? I think it is useful for other modules that want to integrate their own controls ?

Haxxer commented 4 months ago

Since auctioneer is a separate module, people can use item piles without auctioneer. Does it make sense to have that function then?

p4535992 commented 4 months ago

It depends on the use of others in this particular case maybe it also serves internally to this module to make it not do things on a token set as "Auctioneer" ? It doesn't hurt as they say, but if you prefer to put it in the api of the other module it's all the same to me.

Haxxer commented 4 months ago

Keep it, just figured I'd ask 😄