search

fantasycalendar / FoundryVTT-ItemPiles

Other
33 stars 51 forks source link

[BUG] - [Dragonbane] - Can't buy stuff with lower denominations from merchant, when I run out, even though I have a higher one #555

Closed Vass1979 closed 3 months ago

Vass1979 commented 3 months ago

Are you on the latest version of Item Piles? Yes

Have you tried to reset Item Piles' system settings? Yes

Describe the bug I have setup item piles to work with Dragonbane like this: image It works great for the most part. My players can buy from a merchant just fine. The problem comes when they try to buy something that they don't have the exact currency for, but they have a "higher" currency. So for instance, they don't have 2 copper, but they do have 1 silver. The module says they don't have the required currency.

image

As you can see, my player has 3 copper, 1 silver and 2 gold, but can't buy anything that costs 4 or more copper or 2 or more silver.

To Reproduce Steps to reproduce the behavior:

See above

Expected behavior The module should be able to convert a higher currency to a lower one so my player can pay for it.

Screenshots If applicable, add screenshots to help explain your problem.

Setup:

Active modules:

Additional context N/A

Haxxer commented 3 months ago

It is the wrong way around. Try gold 1, silver 0.1, copper 0.01. The order should have tipped you off.

Vass1979 commented 3 months ago

I did try with both orders, same problem

On Fri, 29 Mar 2024, 20:42 Adam Oresten, @.***> wrote:

It is the wrong way around. Try gold 1, silver 0.1, copper 0.01. The order should have tipped you off.

— Reply to this email directly, view it on GitHub https://github.com/fantasycalendar/FoundryVTT-ItemPiles/issues/555#issuecomment-2027717737, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADS44FJY3OVNDQKQQIRWX3Y2W73HAVCNFSM6AAAAABFO4GHH6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRXG4YTONZTG4 . You are receiving this because you authored the thread.Message ID: @.***>

Vass1979 commented 3 months ago

Untitled

Please see the attached image, it shows the setup and also my player trying to buy from merchant

Haxxer commented 3 months ago

Does the items for sale have a drop down for the price denomination in their sheets? If so, item piles may not be able to suss out the total price of the items and thus not know how to best get that from the item.

Vass1979 commented 3 months ago

No dropdown, it is a text field that has the number and then copper, silver, or gold next to it. When I drop it on the merchant, obviously it does not read the price, I have to manually go into every item and add the price myself.

[image: image.png]

So I will edit the item, go to the price settings tab and add a purchase option, using the system currency. [image: image.png]

Is this not the right way?

On Fri, 29 Mar 2024 at 22:47, Adam Oresten @.***> wrote:

Does the items for sale have a drop down for the price denomination in their sheets? If so, item piles may not be able to suss out the total price of the items and thus not know how to best get that from the item.

— Reply to this email directly, view it on GitHub https://github.com/fantasycalendar/FoundryVTT-ItemPiles/issues/555#issuecomment-2027801085, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADS44HSZ5VNM6CQXBPROXTY2XOPZAVCNFSM6AAAAABFO4GHH6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRXHAYDCMBYGU . You are receiving this because you authored the thread.Message ID: @.***>

Vass1979 commented 3 months ago

Please close this issue with my apologies. There is no bug, except in my brain. Someone helped me fix my issue

On Fri, 29 Mar 2024 at 22:47, Adam Oresten @.***> wrote:

Does the items for sale have a drop down for the price denomination in their sheets? If so, item piles may not be able to suss out the total price of the items and thus not know how to best get that from the item.

— Reply to this email directly, view it on GitHub https://github.com/fantasycalendar/FoundryVTT-ItemPiles/issues/555#issuecomment-2027801085, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADS44HSZ5VNM6CQXBPROXTY2XOPZAVCNFSM6AAAAABFO4GHH6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRXHAYDCMBYGU . You are receiving this because you authored the thread.Message ID: @.***>

Haxxer commented 3 months ago

It might help someone else if you explain what went wrong! 🙂

Vass1979 commented 3 months ago

Certainly,

So I hadn't set my Item Price Attribute in System Specific Setting, and that in turn meant I wasn't able to add price per item via Base Price in the item price setting, and was adding a price bia Purchase Options :(

Once I sorted those 2, everything worked perfectly.

For Dragonbane btw the Item price attribute is system.cost

On Sat, 30 Mar 2024 at 22:06, Adam Oresten @.***> wrote:

It might help someone else if you explain what went wrong! 🙂

— Reply to this email directly, view it on GitHub https://github.com/fantasycalendar/FoundryVTT-ItemPiles/issues/555#issuecomment-2028479815, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADS44EW2ZG5R7KPZSM3E3TY24SMZAVCNFSM6AAAAABFO4GHH6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRYGQ3TSOBRGU . You are receiving this because you authored the thread.Message ID: @.***>