fantasycalendar / FoundryVTT-ItemPiles

Other
33 stars 54 forks source link

[BUG] - [Pathfinder 1e] - Incorrect localization keys for currencies #643

Closed LeCuay closed 1 month ago

LeCuay commented 1 month ago

Are you on the latest version of Item Piles? Yes

Have you tried to reset Item Piles' system settings? Yes

Describe the bug Pathfinder 1e v10 has changed the localization keys so the older ones don't display correctly.

Solution: The new keys are PF1.Currency.Full.pp for platin, PF1.Currency.Full.gp for gold PF1.Currency.Full.sp for silver and PF1.Currency.Full.cp for copper.

To Reproduce Steps to reproduce the behavior:

  1. Create any kind of PC or NPC actor
  2. Add currencies
  3. Convert to any kind of item piles object
  4. See error

Expected behavior It is expected for the i18n key to display the name of the currency instead of the key itself.

Screenshots

imagen

Setup:

Active modules:

Additional context This worked for Pathfinder 1e v9.6 so maximum version needs to be updated.

Haxxer commented 1 month ago

I do not maintain the configs for systems I don't play in, please make a pull request to change the relevant properties: https://github.com/fantasycalendar/FoundryVTT-ItemPiles/blob/master/src/systems/pf1.js

mkahvi commented 1 month ago

I'm working on update for the system support that fixes this. I'll push the PR soon, tho I can't fully test it while #642 persists.