fantasycalendar / FoundryVTT-Sequencer

This module implements a basic pipeline that can be used for managing the flow of a set of functions, effects, sounds, and macros.
Other
47 stars 25 forks source link

won't play animations from s3 bucket #117

Closed modzy2 closed 1 year ago

modzy2 commented 1 year ago

Describe the bug WHen I am using an s3 bucket for an autoanimations & jb2a_patreon animation location, either via the overall bucket setting of autoanimations or by an explicit aws s3 URL override for a given weapon attack, the video is not playing. I can track it down as far as _loadtexture call in canvas-effects.js - if a URL is coming in as the value of "file", _loadtexture ends up with this.video as null when it's returning to _initialize(). I can see the URL getting loaded in the console network tab, with 200 status. My s3 url is like https://XXXXXXX.s3.ap-southeast-2.amazonaws.com/jb2a_patreon/Library/Generic/Weapon_Attacks/Melee/Rapier01_01_Regular_White_800x600.webm

Happens in foundry 10 with latest sequencer version.

Active modules:

modzy2 commented 1 year ago

I see where the problem is manifested- in loadVideo in sequencer-file-cache it checks the type of blob if (blob?.type !== "video/webm") return false;

But when mine is loaded from s3 it is "application/octet-stream"

Haxxer commented 1 year ago

Interesting, thank you for the info, if you're able to change that locally, does it work if you replace the video/webm with application/octet-stream?

modzy2 commented 1 year ago

Yes well I just updated the metadata on aws s3 for the testing file and it works now. So I can go and change all the webm metadata content-type to video/webm I'll close this

Haxxer commented 1 year ago

Alright, thank you for the info! I'll add a warning to Sequencer that'll tell any further users of this exact issue.

modzy2 commented 1 year ago

To answer your question correctly: If I comment out the test for "video/webm" it works on a file I have not corrected the metadata for (ie; if the metadata still is application/octet-stream the video still plays correctly after bypassing the check

Haxxer commented 1 year ago

Ah, then I will add it as an accepted type