fantasycalendar / FoundryVTT-Sequencer

This module implements a basic pipeline that can be used for managing the flow of a set of functions, effects, sounds, and macros.
Other
41 stars 17 forks source link

[BUG] 3.2.7 - Animation Manager Locks up, Persist not looping still #249

Closed robgrahamau closed 1 week ago

robgrahamau commented 1 week ago

Even in 3.2.7 the Sequences for persist are still not looping, when you go into the Sequence manager and check the Sequences menus you get the same lock up on the previously mentioned as fixed only now with the actual effects list there. The errors that are being punched out are as follows:

Uncaught (in promise) TypeError: store.subscribe is not a function at subscribe (utils.js:139:22) at get_store_value (utils.js:153:2) at sequence-manager.js:83:9 at Object.update2 [as update] (index.js:69:7) at SequenceManager.RunningSequences.clearFinishedSequences (sequence-manager.js:80:36) at Sequences.svelte:13:38 at run (utils.js:41:9) at Array.map () at Component.js:47:48 at flush (scheduler.js:99:5)Understand this error 2utils.js:139 Uncaught TypeError: store.subscribe is not a function at subscribe (utils.js:139:22) at get_store_value (utils.js:153:2) at sequence-manager.js:83:9 at Object.update2 [as update] (index.js:69:7) at SequenceManager.RunningSequences.clearFinishedSequences (sequence-manager.js:80:36) at HTMLButtonElement.click_handler (Sequences.svelte:34:43)

rolling back to 3.2.5 fixes the persistence issue, but of course the sequences menu is borked there.

To Reproduce run a persistent animation, watch it not loop, go to sequence manager, click sequence watch it error.

Expected behavior that things loop and work,.

Screenshots

Setup:

Active modules:

alot.. but it works fine if i role it back

Additional context Add any other context about the problem here.

Haxxer commented 1 week ago

What is the sequence you're using to make something persist? I cannot replicate it with the original ticket's sequence

robgrahamau commented 1 week ago

The main one is with Automated Animations, but i can replicate it with

new Sequence()
  .effect()
    .file("jb2a.spirit_guardians.greenorange.ring")
    .attachTo(token)
    .persist()
  .play()

image

Those animations aren't looping i can't click on anything on sequence manager to get it to move or change etc. and def on 3.2.7 image

Haxxer commented 1 week ago

I see what's happened, dang merge issues, thanks

robgrahamau commented 1 week ago

Gotta hate it when those happen, just glad you know the cause. Sorry I should have put the macro in as well, just waking up.

Haxxer commented 1 week ago

Fixed in 3.2.8