search

fantasycalendar / FoundryVTT-Sequencer

This module implements a basic pipeline that can be used for managing the flow of a set of functions, effects, sounds, and macros.
Other
41 stars 17 forks source link

[BUG] - endEffects and getEffects cannot handle names with spaces #251

Closed Stexinator closed 23 hours ago

Stexinator commented 6 days ago

Describe the bug endEffects and getEffects cannot handle names with spaces

To Reproduce Steps to reproduce the behavior:

  1. Create an named effect with a space in the name e.g "Ghoul (1)"
  2. Use above methods
  3. See error -> Effects are not ended/found

Expected behavior It finds the effects

Screenshots If applicable, add screenshots to help explain your problem.

Setup:

Active modules:

Haxxer commented 6 days ago

What is the error?

Stexinator commented 6 days ago

There is no error. Simply nothing happens. I clarified it in the initial post

Haxxer commented 6 days ago

I see, the ticket still mentions errors (still does), hence my confusion.

It may be because of ( and ), as those are valid regex. What happens if you name the effect "test test", and try to find it?

Stexinator commented 6 days ago

With "test test" in the name it does not work same for "test(test)" So both are a problem. The " (1)" is automatically append by foundry when you enable automatic numbering.

Haxxer commented 23 hours ago

Fixed in 3.2.10