fantasycalendar / FoundryVTT-Sequencer

This module implements a basic pipeline that can be used for managing the flow of a set of functions, effects, sounds, and macros.
Other
47 stars 25 forks source link

CanvasPan().shake() causes game freeze when frequency = 0 #265

Closed napolitanod closed 2 months ago

napolitanod commented 3 months ago

Describe the bug Running the sequencer .shake() causes Foundry to freeze. This appears to happen when the frequency is 0. It may also required the duration and strength be set > 0. I have not tested around the boundaries of the error, just can recreate it consistently with the macro provided.

To Reproduce Steps to reproduce the behavior:

  1. On a square gridded scene (not sure if grid matters), execute this macro as script: new Sequence().canvasPan().shake({ duration: 1000, strength: 10, frequency: 0 }).play()

Expected behavior No shake occurs due to frequency being 0.

Screenshots n/a

Setup:

Active modules:

Additional context I don't need to run with 0 frequency, simply reporting due to the impact to Foundry when run this way.

Haxxer commented 2 months ago

Fixed in 3.2.12