search

fantasycalendar / FoundryVTT-Sequencer

This module implements a basic pipeline that can be used for managing the flow of a set of functions, effects, sounds, and macros.
Other
47 stars 25 forks source link

[BUG] "stretchTo" breaks looping via "persist" #269

Open TheNittles opened 3 months ago

TheNittles commented 3 months ago

Describe the bug When an effect uses the stretchTo method, the effect will cease looping properly when it's also using the persist method.

To Reproduce Steps to reproduce the behavior:

  1. Create a sequence with an animated effect
  2. Have the effect stretchTo a point of your choice.
  3. Have the effect persist
  4. Let the effect play through its entire animation. The effect will remain on the canvas but stop animating.

Expected behavior The effect animation should loop to the beginning of its animation again,

Screenshots

https://github.com/user-attachments/assets/9b956497-8d7d-41b1-b76a-fcf44832067c

Here's a recording of a macro I use that uses stretchTo to create a conduit between two points. As you can see, it stops animating after one loop.

Setup:

Active modules:

Additional context This problem appears to be exclusive to the 3.2 versions. I tried a few different releases and found that. 3.1.4 is the latest one that does not have this issue.

Haxxer commented 2 months ago

I believe this has been fixed in previous versions

Jason-c-o commented 2 months ago

Coincidence that this was closed 2 hours ago but as of the newest versions (Foundry 12 build 330, Sequencer 3.2.12, and P2e 6.0.4) This is still happening. The webm for the effect stops looping.

chrisk123999 commented 1 day ago

This bug appears to still be happening on version 3.3.6.