fantasycalendar / FoundryVTT-Sequencer

This module implements a basic pipeline that can be used for managing the flow of a set of functions, effects, sounds, and macros.
Other
46 stars 22 forks source link

[BUG] - stretchTo - inLocation is invalid, and must be of type of object, string, placeable object, or document #278

Closed Pentazer closed 1 month ago

Pentazer commented 1 month ago

Describe the bug Magic Missile sample sequencer does not work as copied exactly from the sequencer website. I was testing my macros and found that previously many of my older macros are no longer working. IE:

//Melee Attack
const source = this._getActorToken();
new Sequence()
//Melee
    .effect()
        .file("jb2a.shortsword.melee.01.white.5")   //The Attack
        .atLocation(this.object.target)
        .scale(1)
        .waitUntilFinished(-2600)
//Sound Effect
    .sound()
        .file("_TTRPG_Master_Library/SFX/FFVI/SwordSlash.2")    //Sound Effect
        .fadeInAudio(0)
        .fadeOutAudio(0)
        .waitUntilFinished(-700)
//Melee
    .effect()
        .file("jb2a.shortsword.melee.01.white") //The Attack
        .atLocation(this.object.target)
        .scale(1)
        .waitUntilFinished(-2200)
//Sound Effect
    .sound()
        .file("_TTRPG_Master_Library/SFX/FFVI/SwordSlash.4")    //Sound Effect
        .fadeInAudio(0)
        .fadeOutAudio(0)
.play()

So I decided to copy the magic missile macro to see if something was up only to find that it produces that error.

To Reproduce Steps to reproduce the behavior:

  1. Create macro, copied exactly from sequencer database
  2. Select the Attacker
  3. Target the target
  4. Execute macro

Expected behavior Should fire the magic missile as described on the sequencer database, but it instead produces that error.

Screenshots If applicable, add screenshots to help explain your problem.

Setup:

Active modules:

Additional context Using the two stage sword attack written above absolutely nothing happens anymore. This previously was working on past editions of foundry but now suddenly its not with the latest updates?

Haxxer commented 1 month ago

Did you select two tokens when you ran the macro?

Pentazer commented 1 month ago

Ah okay that got the magic missile example to work. But I'm still facing the issue that the melee attack's not doing anything. If I select A and target B, nothing. if I select A and B and target B, still nothing.

Weirdly enough, it's NOTHING. not even an error message.

Haxxer commented 1 month ago

Your macro is referencing this.object.target, I don't see how that is defined anywhere in the macro. You are most likely dependent on a macro module that adds that as a variable. Not a sequencer issue, since the sample works.

Pentazer commented 1 month ago

Perfect, thanks. That makes a lot of sense. The macro format above are part of a LONG list of animation and sound macros I created for Exalted 3e system I figured they could just migrate over to D&D but it seems like there are element changes between the two so I'll need to make a new set for D&D instead. That clears it up!