fantasycalendar / FoundryVTT-Sequencer

This module implements a basic pipeline that can be used for managing the flow of a set of functions, effects, sounds, and macros.
Other
47 stars 26 forks source link

[BUG] - Sound volume scales on both music and interface volume sliders #294

Closed tyrielv closed 2 months ago

tyrielv commented 2 months ago

Describe the bug Sounds played with sequencer are quiet unless both the music and interface sliders are turned up.

To Reproduce Steps to reproduce the behavior:

  1. Turn all volume sliders up. Play a sound (e.g. with automated animations). The sound is loud.
  2. Turn the interface volume down. Play a sound - it is quiet.
  3. Turn the interface volume back up and the music volume down. Play a sound - it is quiet.

Expected behavior Only one volume slider should control the sound. Based on this it looks like Sequencer is explicitly scaling on the interface slider, then when it plays the sound it is not specifying the audio context and Foundry is defaulting it to the "music" context.

Based on the change description in V12 I think sequencer should stop explicitly scaling the volume based on the interface slider and instead pass the interface audio context when calling the Foundry "play" API.

Setup:

Active modules:

tyrielv commented 2 months ago

292 has a fix for this

Haxxer commented 2 months ago

Fixed in 3.2.16