Tagger isn't working with Pin Notes

fantasycalendar / FoundryVTT-Tagger

Other

6 stars 4 forks source link

Tagger isn't working with Pin Notes #13

Closed matheusferreira closed 2 years ago

matheusferreira commented 2 years ago

I'm trying to fetch some Icons (Pin Note on map) using custom tags, but the method is returning empty array. I was able to fetch a token from this scene using custom tag without any problem. Don't know if is something about Pin Notes that isn't working.

Haxxer commented 2 years ago

Please, could you provide the following information?

Foundry version
Browser and version
If other modules were active, if so, which ones
Does this happen with only Tagger active

matheusferreira commented 2 years ago

Foundry Virtual Tabletop: Version 9, 9.269 Game System: dnd5e, 1.6.1 Browser: Opera GX LVL 3 (core: 87.0.4390.58)

Tried with my modules suite (about over 120, including Monks, Rippers, Mid-Qol, etc). And tried with only Tagger enabled (Running over Find the Culprit!) -> still gives empty array on the Tagger.getByTag(string)

Haxxer commented 2 years ago

Excellent, thank you. I'm on vacation, but I'll look into this once I'm back. Feel free to have a stab at fixing it yourself, the module is open source!

matheusferreira commented 2 years ago

Sorry the delay, I made a Pull Request. I just added Notes documents into the getObjectsFromScene. Please review if more changes need to be made outside the scope of this function for Notes documents be supported. In my tests this simple addition resolved my issue.

Haxxer commented 2 years ago

Thanks for the contribution! I'll merge it in and cut a new version :+1: