Set up travise - Githubissues

fantasyland / daggy

Library for creating tagged constructors.

MIT License

700 stars 29 forks source link

Closed safareli closed 7 years ago

safareli commented 7 years ago

Currently travis is not set up and test are not executed on PR and commits

notgiorgi commented 7 years ago

Also linting setup would be convenient, even some basic setup, like eslint:recommended

I can set it up and send PR

safareli commented 7 years ago

Go for it 🎉

notgiorgi commented 7 years ago

Right after another PR gets merged :+1:

davidchambers commented 7 years ago

Are you still interested in working on this, @notgiorgi?

notgiorgi commented 7 years ago

@davidchambers yep I can do it, totally forgot though :smile:

which styleguide we should use for eslint?

davidchambers commented 7 years ago

which styleguide we should use for eslint?

We already have npm run lint and npm run test. We just need to hook these up to Travis. :)

notgiorgi commented 7 years ago

Oh, I see, you just merged PR, sorry.

Well then I'll setup .travise.yml which runs check and bench tasks :+1: