fantasyland / fantasy-land

Specification for interoperability of common algebraic structures in JavaScript
MIT License
10.08k stars 373 forks source link

s/any/all in README.md #268

Closed dakom closed 7 years ago

dakom commented 7 years ago

fixes https://github.com/fantasyland/fantasy-land/issues/267

davidchambers commented 7 years ago

Please squash the commits and update the commit message. :)

dakom commented 7 years ago

Gladly... how do I do that? hehe

dakom commented 7 years ago

(will try, one min)

davidchambers commented 7 years ago

Gladly... how do I do that?

$ git rebase 82434e7934c9a2f0aa445416a5d601e9d3eabea1^ --interactive  # start with the first commit
$ # change `pick` to `fixup` for second commit
$ git commit --amend
$ # update the commit message
$ git push origin master --force  # update this pull request
dakom commented 7 years ago

I think that did it, ya?

dakom commented 7 years ago

oh I followed the instructions at https://github.com/ginatrapani/todo.txt-android/wiki/Squash-All-Commits-Related-to-a-Single-Issue-into-a-Single-Commit - using "pick" for the first and "squash" for the second.

Same idea?

davidchambers commented 7 years ago

I think that did it, ya?

It would still be good to run git commit --amend to update the commit message. The current commit message no longer accurately describes the change.

dakom commented 7 years ago

Done - and thanks for the help w/ git too!