search

fantasyland / fantasy-land

Specification for interoperability of common algebraic structures in JavaScript
MIT License
10.08k stars 373 forks source link

added Folktale to list #299

Closed Fl4m3Ph03n1x closed 6 years ago

Fl4m3Ph03n1x commented 6 years ago

Added Folktale to the list of compatible implementations.

Fl4m3Ph03n1x commented 6 years ago

Implemented the necessary corrections. Let me know if it is ready to go!

davidchambers commented 6 years ago

LGTM. Would you mind squashing the commits?

Fl4m3Ph03n1x commented 6 years ago

I am afraid I am not familiar enough with the squash functionality. The information I found states that I would have to create a new commit which combines my previous commits. However, this would mean that instead of 3 commits, you now would have 4 ( the first three with the changes, and the last one which is just the union ).

I fail to see how having 4 commits instead of the 3 I made would help you. Perhaps I am missing something?

davidchambers commented 6 years ago

Try running these commands:

$ git rebase 5f4288cb449116747ac6e7e1ad276065303cee03^ --interactive
$ # change ‘pick’ to ‘fixup’ for the second and third commits
$ git push origin master --force
Fl4m3Ph03n1x commented 6 years ago

Done! Let me know if you need anything else!