search

fantasyland / fantasy-land

Specification for interoperability of common algebraic structures in JavaScript
MIT License
10.08k stars 373 forks source link

readme: use prefixed method names #310

Closed davidchambers closed 5 years ago

davidchambers commented 5 years ago

These changes make the document clearer but uglier. Clarity trumps beauty, in this context.

:thumbsup: / :thumbsdown: ?

xaviervia commented 5 years ago

@davidchambers this makes a lot of sense to me, but as an observer tracking what people think about FL, I think it might be a bit of a public relations problem. As it is today, a lot of libraries are de facto partially compatible with FL. After the change, most of them will no longer be (ramda comes to mind).

davidchambers commented 5 years ago

@xaviervia, the spec has required prefixed method names since #146 was released in v1.0.0 back in 2016. This pull request just updates the documentation to make this existing requirement apparent.

p.s. I'm not holding my breath waiting for Ramda to fully support Fantasy Land.

xaviervia commented 5 years ago

Right! Then it would be great to do this, since I was not aware of that requirement and I might not have been the only one missing that

On Thu, Feb 28, 2019, 6:48 PM David Chambers <notifications@github.com wrote:

@xaviervia https://github.com/xaviervia, the spec has required prefixed method names since #146 https://github.com/fantasyland/fantasy-land/pull/146 was released in v1.0.0 https://github.com/fantasyland/fantasy-land/releases/tag/v1.0.0 back in 2016. This pull request just updates the documentation to make this existing requirement apparent.

p.s. I'm not holding my breath waiting for Ramda to fully support Fantasy Land.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fantasyland/fantasy-land/pull/310#issuecomment-468369248, or mute the thread https://github.com/notifications/unsubscribe-auth/AAXSroRmlZaDgAG8zyXtZ9JxdtITZsQQks5vSBZcgaJpZM4a-a2i .