search

fantasyland / fantasy-land

Specification for interoperability of common algebraic structures in JavaScript
MIT License
10.08k stars 373 forks source link

feat: replace dependency picture with a hyperlink map #327

Open jceb opened 3 years ago

jceb commented 3 years ago

I added the hyperlink map from sanctuary-type-classes as I find it much easier to navigate and consume than the two-fold link list + dependency picture.

CrossEye commented 3 years ago

This is a great improvement!

Note that there is a typo in the semigroupoid link.

davidchambers commented 3 years ago

Several people raised concerns when I proposed this change in #160.

jceb commented 3 years ago

Hm, shall we include both, i.e. restore the list, restore the figure and place the pre-formatted map below?

davidchambers commented 3 years ago

@joneshf was concerned about maintenance; perhaps he will chime in. Maintaining the graph in sanctuary-type-classes has not proven onerous. We have a script that automatically updates the readme as part of the release process, and the source is easy to edit in Vim or any other editor with a block mode. Furthermore, changes have not been necessary for several years.

I am in favour of the proposed change, but I think we should incorporate a modified version of the aforementioned script.

joneshf commented 3 years ago

Sorry, I thought I'd responded to this.

I don't really have an opinion on this stuff these days. I say, do what makes sense to you all.

davidchambers commented 11 months ago

I'm in favour of this change, @jceb. Is this pull request up to date? I see that it has been open for more than two years. :sob:

jceb commented 11 months ago

Let me double check😀

jceb commented 11 months ago

I rebased the PR. It's now up-to-date.