search

fanzeyi / pokemon.json

Pokemon dataset in JSON.
719 stars 477 forks source link

[Feature Request] Add Image URL in Pokemon.json #15

Open Purukitto opened 5 years ago

Purukitto commented 5 years ago

Makes it easier to implement

fanzeyi commented 5 years ago

I believe this should be addressed in your PR #16?

Purukitto commented 5 years ago

@fanzeyi No I had only change the file names in that PR. I am working on the commit with all the URL in the JSON.

Purukitto commented 5 years ago

Will push this in the next PR

Purukitto commented 5 years ago

Does the "MS" at the end of every sprite image has any purpose? Or may I remove it ? It would be easier to add the URLs without having to append MS

fanzeyi commented 5 years ago

@Purukitto AFAIK no. I'm not sure why it is there in the first place. Feel free to remove it.

Purukitto commented 5 years ago

I'm not sure why it is there in the first place. Feel free to remove it.

Will do

PolygonPapillon commented 4 years ago

I believe the MS stands for "mini sprite". If the MS was removed there would be no difference between the names of the images in the 'image' file and the 'sprites' file.

fanzeyi commented 4 years ago

@PolygonPapillon Ah! Thanks for the explanation.