search

fanzeyi / pokemon.json

Pokemon dataset in JSON.
719 stars 477 forks source link

Update moves.json #20

Closed Purukitto closed 4 years ago

Purukitto commented 5 years ago

Converted Unicode to relevant Japanese and Chinese characters (ref #19 )

Also updated new moves added in Ultra Sun and Ultra Moon (ref #5 ) References:

Also see PR #18

fanzeyi commented 5 years ago

I would prefer to not directly include Unicode characters in the file. It would be more easier to process in various environments (weird encoding issues etc, sadly there are situations where UTF-8 is not the default encoding). Can you still keep the "\u" escaping and add the changes?

Thanks.

Purukitto commented 5 years ago

@fanzeyi

I would prefer to not directly include Unicode characters in the file. It would be more easier to process in various environments (weird encoding issues etc, sadly there are situations where UTF-8 is not the default encoding). Can you still keep the "\u" escaping and add the changes?

Sure can , But moves is currently the only file with this encoding. Would you like me to convert the Japanese/Chinese characters in other files to unicode as well? (eg. Pokedex)

We should either keep all files in Unicode or in UTF-8.

Also I believe for most practical purposes UTF-8 will work, also helps to keep the file legible and useful to beginners. People working in complex environments should be able to covert the UTF-8 to Unicode. So IMHO keeping it in UTF-8 should be for the best