fao89 / pulp_ansible

A Pulp plugin that manages Ansible content, i.e. roles, collections
https://pulp-ansible.readthedocs.io/en/latest/
GNU General Public License v2.0
0 stars 0 forks source link

500 when publishing a repository without any versions #4

Open fao89 opened 2 years ago

fao89 commented 2 years ago

Author: daviddavis (daviddavis)

Redmine Issue: 3610, https://pulp.plan.io/issues/3610


Copied from pulp_file. Was able to reproduce this with an ansible publisher.

~/3/pulp_ansible ❯ http POST http://dev.pulp3:8000/api/v3/publishers/ansible/007682b4-f522-469b-92c9-baeca276529a/publish/ repository=http://dev.pulp3:8000/api/v3/repositories/96a7048f-bda6-4ccc-8317-a8dca80defae/
HTTP/1.0 500 Internal Server Error

Traceback:  

File "/home/vagrant/.virtualenvs/pulp/lib64/python3.6/site-packages/django/core/handlers/exception.py" in inner
  41.             response = get_response(request)

File "/home/vagrant/.virtualenvs/pulp/lib64/python3.6/site-packages/django/core/handlers/base.py" in _legacy_get_response
  249.             response = self._get_response(request)

File "/home/vagrant/.virtualenvs/pulp/lib64/python3.6/site-packages/django/core/handlers/base.py" in _get_response
  187.                 response = self.process_exception_by_middleware(e, request)

File "/home/vagrant/.virtualenvs/pulp/lib64/python3.6/site-packages/django/core/handlers/base.py" in _get_response
  185.                 response = wrapped_callback(request, *callback_args, **callback_kwargs)

File "/home/vagrant/.virtualenvs/pulp/lib64/python3.6/site-packages/django/views/decorators/csrf.py" in wrapped_view
  58.         return view_func(*args, **kwargs)

File "/home/vagrant/.virtualenvs/pulp/lib64/python3.6/site-packages/rest_framework/viewsets.py" in view
  95.             return self.dispatch(request, *args, **kwargs)

File "/home/vagrant/.virtualenvs/pulp/lib64/python3.6/site-packages/rest_framework/views.py" in dispatch
  494.             response = self.handle_exception(exc)

File "/home/vagrant/.virtualenvs/pulp/lib64/python3.6/site-packages/rest_framework/views.py" in handle_exception
  454.             self.raise_uncaught_exception(exc)

File "/home/vagrant/.virtualenvs/pulp/lib64/python3.6/site-packages/rest_framework/views.py" in dispatch
  491.             response = handler(request, *args, **kwargs)

File "/home/vagrant/devel/pulp_file/pulp_file/app/viewsets.py" in publish
  147.             [repository_version.repository, publisher],

Exception Type: AttributeError at /api/v3/publishers/file/007682b4-f522-469b-92c9-baeca276529a/publish/
Exception Value: 'NoneType' object has no attribute 'repository'
fao89 commented 2 years ago

From: daviddavis (daviddavis) Date: 2018-04-26T22:35:00Z


Resetting values after copy.

fao89 commented 2 years ago

From: @dralley (dalley) Date: 2018-05-01T14:28:20Z


The fix for this same issue from the file plugin can essentially just be copied over.

https://github.com/pulp/pulp_file/pull/85

Or move it to core and make the associated changes to the plugins.

fao89 commented 2 years ago

From: amacdona@redhat.com (amacdona@redhat.com) Date: 2018-06-14T12:40:50Z


https://github.com/pulp/pulp/pull/3524 adds the serializers to core, so if Ansible is updated to use them, it will fix this issue.

fao89 commented 2 years ago

From: daviddavis (daviddavis) Date: 2018-06-14T17:48:06Z


Excellent, thanks @asmacdo.