search

faph / action-jekyll

A GitHub Action for just building Jekyll web sites
https://hub.docker.com/r/faph/action-jekyll-2
MIT License
1 stars 3 forks source link

Bundler version may be out of sync with repository #3

Open scowalt opened 4 years ago

scowalt commented 4 years ago

This action is currently hard-coded to use ruby 2.6.4. It's possible that the target repository was bundled with a newer version of the bundler. This will cause errors when trying to install the target bundle.

Once possible solution would be to take the ruby version as an argument, or the bundler version as an argument. I don't know enough about Ruby or about Github Actions to know the most appropriate solution.

faph commented 4 years ago

What about if we have different versions/branches of this GH Action, based on major.minor Ruby version? Which version of Ruby do you intend to run?

scowalt commented 4 years ago

I'm currently on ruby 2.7.0 with bundler version 2.1.4.

Having a different branch for each ruby version doesn't sound very maintainable, unless you plan on programmatically creating branches when new versions of ruby are released.

Maybe the docker VM can conditionally upgrade from 2.6.4 => x.x.x based on a passed-in argument? Although this kind of defeats the purpose of having a docker machine to begin with.

I wish there was a way to make the Dockerfile itself dynamic, but I don't know if that's possible.

(I likely won't be able to look at this any time soon, and I'm using a local version of this action in my .github/actions for my project. Just wanted to share some thoughts :) )