search

fappel / xiliary

Auxiliary libraries for Eclipse, JUnit and Java development in general.
http://fappel.github.io/xiliary
Eclipse Public License 1.0
61 stars 13 forks source link

[Clean Sheet] Code assist in ABAP Development Tools doesn't work #115

Open DonTsetsi opened 7 months ago

DonTsetsi commented 7 months ago

Code assist in ABAP relies on a request to the backend which doesn't execute when I use the Clean Sheet and Cream themes. The issue doesn't occur with other themes. image

fappel commented 7 months ago

Thanks for your interest in Clean Sheet. Are you using Windows? Are you sure that the backend request gets not executed? I ask because on rare occasions, particular layout programmings lever out the scrollbar adapters mechanism for windows and because of this the updated content is simply not shown as its size is set to (0,0) (If I remember correctly...). If the latter is the case, there is not much to do about it, unfortunately. Regards Frank

DonTsetsi commented 7 months ago

Hello, Yes I am using Windows. I am not 100% sure whether the request is not sent or the results are not processed. The Loading code completion results... message indicates that the request results were not received. If there are suggestions that don't rely on the request, they show up: image

Regards, Tsvetelin

DonTsetsi commented 7 months ago

I was able to verify that the request is sent and the reply is received: image

The code completion pop-up does not update with the received results.

I am also not able to view a request while I'm using one of the themes. When I double-click on the request I get the following error: image

After switching to a different theme, I am able to view the request just fine: image

Could it be that both issues have the same cause?

The logged error when trying to view the request: image

There is no logged error when using code assist.

fappel commented 7 months ago

Hm, have you tried to resize the completion popup after receiving the result? This might force a relayout of the content, but that's just a guess. However, it might help to narrow down the problem, whether it's just a layout issue or if something deeper is going on. Regarding the Stacktrace, I assume that this is a different problem, since there is no trace with the completion popup and the exception shows clearly that there are illegal weight values set to the dialog's sashform. It seems to me that the completion popup does not have a sash component, but I might be wrong.

Unfortunately, the exception message does not state what weights are attempted to set... it's a bit strange since there is no com.codeaffine.eclipse.swt related trace item, so it might be that the weight calculation relies on some attributes of a styled text of scrolled composite adapter which differs from the values that would be given from the wrapped component(s). I don't know if the ABAP stuff is open source, which would open an opportunity to debug the problems in more depth, but even if so I would lack the time to do so in the foreseeable future. But if you like to try, the AbstractLoggingDetailsDialog.updateMessageBodyUI(AbstractLoggingDetailDialog.java 480) would be a good starting place for setting a break point...