search

fappel / xiliary

Auxiliary libraries for Eclipse, JUnit and Java development in general.
http://fappel.github.io/xiliary
Eclipse Public License 1.0
61 stars 13 forks source link

Flat scroll bars break trees in Eclipse 2024-06 #116

Open PyvesB opened 4 months ago

PyvesB commented 4 months ago

Hello 👋🏻

The issue was originally reported in https://github.com/PyvesB/eclipse-planet-themes/issues/17, but I traced it back to the flat scroll bars provided by Xiliary. It seems that they break tree rendering in Eclipse 2024-06, which will be officially released on June 12th. Here's a screenshot of what happens with Clean Sheet: Screenshot 2024-06-08 145854

Any clue on what may be happening?

fappel commented 4 months ago

Hi, that looks pretty bad. Unfortunately, I currently do not have any MS Windows OS at my disposal nor do I have the time to investigate this thoroughly. At a first glance, it might have to do with the changes of https://github.com/eclipse-platform/eclipse.platform.swt/commit/f80937230f0caf83f0c38fd6536654b301b8934d and/or https://github.com/eclipse-platform/eclipse.platform.swt/commit/0b0addf51011dc8dfb57552674fad3e502125e92 to Tree, TreeColumn, and TreeItem introducing DPI zoom changes to basic controls. As the changes of other topics date back years these commits seem to match the timeframe, right? Since the TreeAdapter is an extension of Tree that reparent the adapted tree instance to the adapter instance (and might do some other ugly stuff on internals that I forgot), this might interfere with whatever new DPI Zoom mechanism is doing or it might causes a dangling reference to some parent attributes or the like.

adi291 commented 4 months ago

Please, fix this bug. I really need it!

jfmenard commented 1 month ago

Very unfortunate this theme is not maintained anymore, it was the last hope to have a nice looking, modern Eclipse UI... Was even hoping for a dark version of this theme, which would be the ultimate solution to compete with the other IDEs.

Ho well... :-(