search

faraazahmad / shellrb

A unix-like shell built in Ruby
MIT License
35 stars 24 forks source link

mkdir command with spec file #44

Closed ekeast closed 6 years ago

ekeast commented 6 years ago

Here is my code for the mkdir.rb file and the spec file. This is my first contribution to an open source project, so please bear with me if there are any mistakes!

faraazahmad commented 6 years ago

Awesome! You might wanna check your comments a little ;)

faraazahmad commented 6 years ago

using unless...else...end is not recommended. Use an if...else...end block instead

ekeast commented 6 years ago

Thanks a lot! I've made those changes and committed. Please feel free to let me know if further changes are required.