search

farach / huggingfaceR

Hugging Face state-of-the-art models in R
Other
142 stars 17 forks source link

Update zzz.R #20

Closed tomazweiss closed 2 years ago

tomazweiss commented 2 years ago

Updated get_current_python_environment() to work on Windows.

farach commented 2 years ago

This will work as well. I believe that reticulate::py_install() function takes either the env name or full path. I was doing the full path to match what we are doing with non-Windows users. Do you have a strong preference?

tomazweiss commented 2 years ago

Oh, I see. No strong preferences on my side :)

farach commented 2 years ago

I'll leave as is then for the sake of keeping things the same. Appreciate you flagging this down. I'm still working on the other install issue. The approach you mentioned should work and I aim to implement soon! Really appreciate you bringing that up as well. Thanks!