search

faradayio / cage

Develop and deploy complex Docker applications
http://cage.faraday.io
Apache License 2.0
307 stars 26 forks source link

Don't let docker create the src directory #23

Closed erithmetic closed 7 years ago

erithmetic commented 7 years ago

If you have a library defined that gets mapped to a volume, any container that runs that uses that volume will create ./src/library, which means src is now owned by root. This breaks cage repo clone.

emk commented 7 years ago

This is almost certainly a a different bug: We shouldn't be generating library mounts for containers unless the library directory already exists locally.

emk commented 7 years ago

I think I have a fix for this in 250203f. I was missing a check for mounting library repos.

Could you please verify this either against master or against 0.0.23 when it comes out?